search

camallo / dkregistry-rs

A pure-Rust asynchronous library for Docker Registry API v2
Apache License 2.0
62 stars 39 forks source link

v2/client: add accept_invalid_certs option #158

Closed steveej closed 4 years ago

steveej commented 4 years ago

This allows to ignore invalid TLS certificates which can be useful in test environments.

lucab commented 4 years ago

LGTM, but what do you think about mirroring the underlying name (i.e. keeping the danger prefix)?

steveej commented 4 years ago

what do you think about mirroring the underlying name (i.e. keeping the danger prefix)?

A bit too dramatic for my taste, hence I skipped it. I won't oppose adding it if you prefer that though.

lucab commented 4 years ago

But the audience loves drama! Jokes aside, it was only to keep consistency with the reqwest client. We can freely take a different route. LGTM.