search

camallo / dkregistry-rs

A pure-Rust asynchronous library for Docker Registry API v2
Apache License 2.0
62 stars 39 forks source link

Cargo: downgrade async-stream for compatibility with rust 1.43 #187

Closed steveej closed 4 years ago

steveej commented 4 years ago

I didn't manage to change this dependency from the consumer of dkregistry so I'm resorting to downgrading it here.

Includes #190.

lucab commented 4 years ago

I doubt this is really tenable because 1.43 is quite ancient at this point, but if you specifically need this because the RHEL toolset is outdated then there should be a Travis job to make sure we don't accidentally break your required MSRV with other dependencies.

steveej commented 4 years ago

Thanks @lucab. I understand that 1.43 is ancient and I hope this constraint won't last for too long and doesn't create too much friction along the way.

I added 1.43.1 to the version matrix for travis in https://github.com/camallo/dkregistry-rs/pull/190

lucab commented 4 years ago

@steveeJ the Travis change looks nice, thanks. I think you can throw that directly into this PR, so that if it is still green we can merge and be sure that everything else is ok too.

steveej commented 4 years ago

Thanks @lucab. I rebased on top of #190. I think GitHub will automatically close the other one when we merge this. Let's try :slightly_smiling_face:

lucab commented 4 years ago

LGTM, and the Travis 1.43.1 run is indeed green.