search

camallo / dkregistry-rs

A pure-Rust asynchronous library for Docker Registry API v2
Apache License 2.0
62 stars 39 forks source link

v2/tags: follow results on multiple pages #48

Closed lucab closed 5 years ago

lucab commented 6 years ago

This adds full support for tags pagination, with per-page limit and next page following.

lucab commented 6 years ago

/cc @steveeJ

lucab commented 6 years ago

I've realised I've left a few unwraps around and forgot to update the mock tests. Still fine for a first review pass, but marked back as WIP.

steveej commented 5 years ago

What are the missing steps in the mock tests? I can continue on top of your work, after #49, if you like

lucab commented 5 years ago

@steveeJ this TODO https://github.com/camallo/dkregistry-rs/blob/86e85b4c70d54f81b9bd8722abe9f9a0c4777ffb/tests/mock/tags.rs#L81

lucab commented 5 years ago

Got rid of the unwraps in the meanwhile.

lucab commented 5 years ago

And the mock TODO too. This should be ready to review, but we may still want to land #49 first.

lucab commented 5 years ago

@steveeJ rebased to resolve conflicts.

lucab commented 5 years ago

I've rebased this to current master. I guess we can tag 0.2.0 once this is merged.

lucab commented 5 years ago

I've already tagged 0.2.0

Oh. Then unfortunately your tag has a mismatch with the manifest version: https://github.com/camallo/dkregistry-rs/blob/0.2.0/Cargo.toml#L3. To avoid such problems in the future, I'll introduce cargo-release metadata here too and use the same process we have for other coreos crate (which looks like https://github.com/coreos/openssh-keys/pull/31).