search

camallo / dkregistry-rs

A pure-Rust asynchronous library for Docker Registry API v2
Apache License 2.0
62 stars 39 forks source link

blobs: switch from hyper to reqwest #65

Closed steveej closed 5 years ago

steveej commented 5 years ago

This change is motivated by improved status error handling. Before this change even error codes would be treated as success and the body would contain the HTML formatted error message passed through to the caller. Instead of reimplementing proper error handling here we can make use of the reqwest library which already does it.

Closes #63 Progress on #44

lucab commented 5 years ago

@steveeJ does this close #63 or is it a prerequisite for that? I didn't see the HTTP status check here.

steveej commented 5 years ago

does this close #63 or is it a prerequisite for that? I didn't see the HTTP status check here.

TL;DR: It does now, thanks for pointing this out :smile:

I thought it already did because I was able to trigger an error when I cross tested the changes from cincinnati, but I must've made a mistake while testing it