search

camaradesuk / ASySD

https://camaradesuk.github.io/ASySD/
GNU General Public License v3.0
12 stars 5 forks source link

Decide on return of dedup_citations() when manual = FALSE #49

Open LukasWallrich opened 1 month ago

LukasWallrich commented 1 month ago

Currently, dedup_citations is documented as always returning a list, yet it returns a df when manual = FALSE. That needs to be aligned - @kaitlynhair, I think we went back and forth there - can you decide on the interface, so that we can align it?

LukasWallrich commented 1 month ago

In the CiteSource discussion, our tendency is that it should be a list, so that changing manual = from TRUE to FALSE does not break subsequent code.