A few minor issues - Githubissues

camaradesuk / ASySD

https://camaradesuk.github.io/ASySD/

GNU General Public License v3.0

11 stars 5 forks source link

A few minor issues #8

Open LukasWallrich opened 1 year ago

LukasWallrich commented 1 year ago

When using dedup_refs, I encountered a few minor issues:

the returned tibble in unique is grouped, which can lead to issues in further analysis (e.g., when using summarise). Maybe better ungroup() it before returning?
the message Joining, by = "record_id" is shown in between your status updates - maybe specify by = in all join calls?

It would also be better practice to use message() rather than print() for the status updates - for example when one wants to use ASySD in a Rmd document where the status updates are not very helpful.

LukasWallrich commented 1 year ago

Also, since you are giving such nice status updates, might it be worth including the number of duplications and potential duplicates? I imagine that that is something nearly every user will want to know right after running dedup_citations?

kaitlynhair commented 1 year ago

All great suggestions! I have now fixed most of these issues. Haven't added the N potential duplicates message yet - might want to make some improvements to manual dedup functionality first.

LukasWallrich commented 1 year ago

Copying two things here from a CiteSource issue:

[ ] Does this rename make sense? raw_citations$pages <- raw_citations$start_page? Should it not then be start_page-end_page?
[ ] Do we really want to reset record_ids? I would leave it up to the user to provide them if they want to, and just check if they are unique - i.e change raw_citations$record_id <- ""