search

camaradesuk / ASySD

https://camaradesuk.github.io/ASySD/
GNU General Public License v3.0
12 stars 5 forks source link

Document required fields and/or rethink requirements #9

Closed LukasWallrich closed 1 year ago

LukasWallrich commented 1 year ago

Currently ASySD fails if one of the following fields are missing:

select(author, title, year, journal, abstract, doi, number, pages, volume, isbn, record_id, label, source)

It would be great to document which fields are required and to throw a clearer error message when required fields are missing ... and possible you could also automatically add some missing fields (setting them to NA) - e.g. ISBN?

kaitlynhair commented 1 year ago

Good point Lukas. I have been working on some improvements in the v1 branch which will be merged shortly. I have now added a warning to notify users of what fields are missing and set missing fields to NA - coming in V1.0

kaitlynhair commented 1 year ago

Now added a menu to allow users to proceed (or not proceed) with dedup if key fields are missing and have documented requirements in readme.