Required 'currency' information in API design

[PedroDiez]

Problem description 'currency' use within the API design (binding and GET endpoints)

During 20th July meeting, VF raised need of indicating a currency in binding and fetch blockchain functionality. Within a given blockchain, several currencies may be used, so it might not be considered as mandatory in design

Possible evolution Set currency as optional (just a string or an array of strings)

Alternative solution

Additional context N/A

[PedroDiez]

Internally commented.

[PedroDiez]

Proposal in 10/AGO meeting.

Make currency as optional Array:

Used in

GET Response Retrieves Blockchain Public Address associated to a phone_number.

POST Request Binds Blockchain Public Address to a phone_number

Exception Added in POST Request:

Currency indication is required ("code": "BLOCKCHAIN_PUBLIC_ADDRESS.CURRENCY_REQUIRED","message": "One currency is required")

VF seems OK with proposal DT would like to check some corner cases to see whether some scam scenario

[PedroDiez]

@grgpapadopoulos Have you checked this point? Just to have your feedback on this

[PedroDiez]

31/AGO: Issue is kept open

Some topics talked. As commented, please @grgpapadopoulos, @sebKoeller, @engst03, @ksl4dtit you can provide feedback here

Points commented:

• Model discussion:

  Blockchain address that allows several currencies Each blockchain address is "attached" to a specific currency

• Blockchain - chain_ids: https://chainagnostic.org/CAIPs/caip-2

• Blockchain "type" Levels:

  Level 1: ethereum, ... Level 2: polygon, celo...

[ghost]

What's the meaning behind this "one currency is required" exception? Can you elaborate on this?

[PedroDiez]

@grgpapadopoulos Can you provide feedback about the "scum" scenarios you would like to check and relationship with this topic?

[PedroDiez]

What's the meaning behind this "one currency is required" exception? Can you elaborate on this?

Pedro: This exception is for the case when underlying blockchain address is restricted to be used with a set of specific currency(ies). So in the binding, they are indicated the specific currencies allowed to be used within the blockchain

[ghost]

Pedro: This exception is for the case when underlying blockchain address is restricted to be used with a set of specific currency(ies). So in the binding, they are indicated the specific currencies allowed to be used within the blockchain

The currency array can be left empty, so why would we need this exception?

[PedroDiez]

Pedro: This exception is for the case when underlying blockchain address is restricted to be used with a set of specific currency(ies). So in the binding, they are indicated the specific currencies allowed to be used within the blockchain

The currency array can be left empty, so why would we need this exception?

Yes, it can be empty for the scenario of no setting any restriction. However, BE logic may required in some blockchain to have explicitly the currency indicated

[PedroDiez]

Can we close then this topic?

[ghost]

Yep.

[grgpapadopoulos]

Hello, sorry for this delayed response, it's ok, plz close the topic

[PedroDiez]

Agreed to be closed during the meeting 06/oct