Closed PedroDiez closed 11 months ago
@jordonezlucena @PedroDiez : Please make sure that all new codeowners are part of the Sub Project before merging such a PR. Klaus is missing in the moment, so the Codeowners file is not valid!
@jordonezlucena @PedroDiez : Please make sure that all new codeowners are part of the Sub Project before merging such a PR. Klaus is missing in the moment, so the Codeowners file is not valid!
@MarkusKuemmerle I was aware of that, but wanted to trigger in advance. Once they become members, this config file will apply and we will see them as effective codeowners, isn't?
@pedrodiez : The Codeowners file is a technical file used by some tools automatically. If it‘s invalid this tools don‘t work. So we should care about having a valid file all the time sent with Telekom-IT Corporate Mobile Service Am 11. August 2023 um 15:41:39 MESZ schrieb Pedro Díez García @.***>:
@jordonezlucenahttps://github.com/jordonezlucena @PedroDiezhttps://github.com/PedroDiez : Please make sure that all new codeowners are part of the Sub Project before merging such a PR. Klaus is missing in the moment, so the Codeowners file is not valid!
@MarkusKuemmerlehttps://github.com/MarkusKuemmerle I was aware of that, but wanted to trigger in advance. Once they become members, this config file will apply and we will see them as effective codeowners, isn't?
— Reply to this email directly, view it on GitHubhttps://github.com/camaraproject/BlockchainPublicAddress/pull/15#issuecomment-1674813252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUVD2SBMX26JUPV4YTBO7HLXUYZAZANCNFSM6AAAAAA3L2KLYM. You are receiving this because you were mentioned.Message ID: @.***>
Ok Markus I revert change now in a new PR
What type of PR is this?
What this PR does / why we need it:
Update Codeowners
Which issue(s) this PR fixes:
Fixes Issue https://github.com/camaraproject/BlockchainPublicAddress/issues/10