camaraproject / BlockchainPublicAddress

Repository to describe, develop, document and test the Blockchain Public Address API family
Apache License 2.0
6 stars 4 forks source link

update_codeowners #15

Closed PedroDiez closed 11 months ago

PedroDiez commented 11 months ago

What type of PR is this?

What this PR does / why we need it:

Update Codeowners

Which issue(s) this PR fixes:

Fixes Issue https://github.com/camaraproject/BlockchainPublicAddress/issues/10

MarkusKuemmerle commented 11 months ago

@jordonezlucena @PedroDiez : Please make sure that all new codeowners are part of the Sub Project before merging such a PR. Klaus is missing in the moment, so the Codeowners file is not valid!

PedroDiez commented 11 months ago

@jordonezlucena @PedroDiez : Please make sure that all new codeowners are part of the Sub Project before merging such a PR. Klaus is missing in the moment, so the Codeowners file is not valid!

@MarkusKuemmerle I was aware of that, but wanted to trigger in advance. Once they become members, this config file will apply and we will see them as effective codeowners, isn't?

MarkusKuemmerle commented 11 months ago

@pedrodiez : The Codeowners file is a technical file used by some tools automatically. If it‘s invalid this tools don‘t work. So we should care about having a valid file all the time sent with Telekom-IT Corporate Mobile Service Am 11. August 2023 um 15:41:39 MESZ schrieb Pedro Díez García @.***>:

@jordonezlucenahttps://github.com/jordonezlucena @PedroDiezhttps://github.com/PedroDiez : Please make sure that all new codeowners are part of the Sub Project before merging such a PR. Klaus is missing in the moment, so the Codeowners file is not valid!

@MarkusKuemmerlehttps://github.com/MarkusKuemmerle I was aware of that, but wanted to trigger in advance. Once they become members, this config file will apply and we will see them as effective codeowners, isn't?

— Reply to this email directly, view it on GitHubhttps://github.com/camaraproject/BlockchainPublicAddress/pull/15#issuecomment-1674813252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUVD2SBMX26JUPV4YTBO7HLXUYZAZANCNFSM6AAAAAA3L2KLYM. You are receiving this because you were mentioned.Message ID: @.***>

PedroDiez commented 11 months ago

Ok Markus I revert change now in a new PR