search

camaraproject / BlockchainPublicAddress

Repository to describe, develop, document and test the Blockchain Public Address API family
Apache License 2.0
6 stars 4 forks source link

update_codeowners_file #24

Closed PedroDiez closed 9 months ago

PedroDiez commented 9 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

PR to include as codeowners Sebastian and Giorgios. More Codeowners can be included in future

Which issue(s) this PR fixes:

Fixes #10

Special notes for reviewers:

N/A

PedroDiez commented 9 months ago

@grgpapadopoulos, @sebKoeller FYI I will comment today and merge after meeting

PedroDiez commented 9 months ago

Merged after meeting

ghost commented 9 months ago

@PedroDiez Why is this showing an error?

MarkusKuemmerle commented 9 months ago

The merge triggers the admins to provide write permission for the new codeowners. No it’s valid 😊

Von: Sebastian Köller @.> Gesendet: Donnerstag, 5. Oktober 2023 15:01 An: camaraproject/BlockchainPublicAddress @.> Cc: Subscribed @.***> Betreff: Re: [camaraproject/BlockchainPublicAddress] update_codeowners_file (PR #24)

@PedroDiezhttps://github.com/PedroDiez Why is this showing an error?

— Reply to this email directly, view it on GitHubhttps://github.com/camaraproject/BlockchainPublicAddress/pull/24#issuecomment-1748853836, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUVD2SC3T4YVMXCRNGVPHNTX52VRXAVCNFSM6AAAAAA5RJOJIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYHA2TGOBTGY. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

PedroDiez commented 9 months ago

image

Hi, maybe missing something. GIT checking indicates the file is valid, isn't?