camaraproject / BlockchainPublicAddress

Repository to describe, develop, document and test the Blockchain Public Address API family
Apache License 2.0
6 stars 4 forks source link

blockchain_identification_and_alignment_topics #30

Closed PedroDiez closed 7 months ago

PedroDiez commented 8 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

This PR is intended to cover:

Which issue(s) this PR fixes:

Fixes #19 Alignment with Commonalities#57

Special notes for reviewers:

Blockchain Identification parameter name set to blockchainNetworkId

PedroDiez commented 8 months ago

Thanks @grgpapadopoulos, @sebKoeller for the review so far. I will be adding the exception pending

rartych commented 8 months ago

I guess it would be more correct to use the expression "associated with" instead of "associated to" in the descriptions. There is again discussion in Commonalities about including headers like x-correlator in CAMARA OpenAPI files, when the issue https://github.com/camaraproject/Commonalities/issues/77 is clarified we should align the specification here. The same with operation tags - https://github.com/camaraproject/Commonalities/issues/80

PedroDiez commented 8 months ago

I guess it would be more correct to use the expression "associated with" instead of "associated to" in the descriptions. There is again discussion in Commonalities about including headers like x-correlator in CAMARA OpenAPI files, when the issue camaraproject/Commonalities#77 is clarified we should align the specification here. The same with operation tags - camaraproject/Commonalities#80

Thanks Rafal!

PedroDiez commented 7 months ago

Thanks @grgpapadopoulos, @sebKoeller

Will merge it during meeting