Add 404 Exception to other API endpoints that have {paymentId} in API path

camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family

Apache License 2.0

9 stars 9 forks source link

Add 404 Exception to other API endpoints that have {paymentId} in API path #107

Closed PedroDiez closed 7 months ago

PedroDiez commented 9 months ago

Problem description

Currently it is considered 404 Exception NOT_FOUND in retrievePayment ( GET /payments/{paymentId} ) endpoint, to cover the case when the paymentId does not exist.

Same scenario would happen in the case of the following endpoints:

confirmPayment endpoint ( POST /payments/{paymentId}/confirm )
cancelPayment endpoint ( POST /payments/{paymentId}/cancel )

Possible evolution

Add 404 exception NOT_FOUND to those two endpoints

Additional context

N/A

PedroDiez commented 8 months ago

25/OCT: To be included in next PR generation

PedroDiez commented 7 months ago

Closed as per PR#119 MERGED