camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family
Apache License 2.0
9 stars 9 forks source link

Improve_Checkout_Model_Error_and_Notifications_(v0.6) #51

Closed PedroDiez closed 1 year ago

PedroDiez commented 1 year ago

NOTE:

PedroDiez commented 1 year ago

Thanks Ludovic! yes it seems some errors, i need to check in detail

PedroDiez commented 1 year ago

You mention in the swagger: This resource has one operation to send events to the notification_url, when provided by the API client in the purchase creation.

But the purchase data structure did not features this notification_url attribute.

Is it on purpose (to be updated later) or not? Thanks

Thanks Ludovic, yes i missed to indcate the param. Already made a commit to fix it I am going to also check optionality of some parameters in this proposal taking advantage of it, based on open questions issue.

PedroDiez commented 1 year ago

Thanks for the review. Merging it