Closed PedroDiez closed 1 year ago
Q4-ERICSSON: Management of Purchase LifeCycle
There is more than one option to manage "Purchase" concept lifecycle:
About questions Q5 and Q6, we are thinking about them and provide feedback (initially it seems no problem in making it optional, we are doing an assesment)
Q2-STC: In create purchase request does the total_amount includes merchant fee?
YES
Q5-ERICSSON: merchant.fee && Q6-STC: Concept of merchant.id && Q7-order.id
Proposal updated accordingly in v0.6.0
Update Q1 and Q3
Still under internal analysis
Q1-STC: Create a new purchase - no customer details like mobile number (MSISDN)
phone number will be included in payment request for both one-step and two-step cases, being optional parameter.
There are cases where phone number can be inferred from authentication context, therefore contained within an opaque JWT-based Authorization Header:
On the other hand there are scenarios where phone number has to be explicitly indicated:
Considering this rationale, phone number will be included in payment request being optional parameter
Q3-STC: Prepare/cancel/confirm payment – no payload – can we move the path parameter to payload as it is a POST call
POST call is not forbidden to have an empty body, indeed POST call can be mainly used to:
To create a resource, then usually a representation of the resource is provided
To perform an specific action over a resource. The resource is the "purchase" represented by purchase_id, then the reason to model it within the path URL
Therefore that is the reason, from design point of view to keep it as currently is. Anyway in Payment request (1-step and 2-step), now it is indicated phone number as input parameter
Closed as PR https://github.com/camaraproject/CarrierBillingCheckOut/pull/64 is already triggered
Issue to track questions & comments received regarding Carrier Billing Checkout Proposal