camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family
Apache License 2.0
9 stars 9 forks source link

OPEN QUESTIONS - Carrier Billing Checkout Proposal #54

Closed PedroDiez closed 1 year ago

PedroDiez commented 1 year ago

Issue to track questions & comments received regarding Carrier Billing Checkout Proposal

PedroDiez commented 1 year ago

Q4-ERICSSON: Management of Purchase LifeCycle

There is more than one option to manage "Purchase" concept lifecycle:

PedroDiez commented 1 year ago

About questions Q5 and Q6, we are thinking about them and provide feedback (initially it seems no problem in making it optional, we are doing an assesment)

PedroDiez commented 1 year ago

Q2-STC: In create purchase request does the total_amount includes merchant fee?

YES

PedroDiez commented 1 year ago

Q5-ERICSSON: merchant.fee && Q6-STC: Concept of merchant.id && Q7-order.id

Proposal updated accordingly in v0.6.0

PedroDiez commented 1 year ago

Update Q1 and Q3

Still under internal analysis

PedroDiez commented 1 year ago

Q1-STC: Create a new purchase - no customer details like mobile number (MSISDN)

phone number will be included in payment request for both one-step and two-step cases, being optional parameter.

There are cases where phone number can be inferred from authentication context, therefore contained within an opaque JWT-based Authorization Header:

On the other hand there are scenarios where phone number has to be explicitly indicated:

Considering this rationale, phone number will be included in payment request being optional parameter

PedroDiez commented 1 year ago

Q3-STC: Prepare/cancel/confirm payment – no payload – can we move the path parameter to payload as it is a POST call

POST call is not forbidden to have an empty body, indeed POST call can be mainly used to:

Therefore that is the reason, from design point of view to keep it as currently is. Anyway in Payment request (1-step and 2-step), now it is indicated phone number as input parameter

PedroDiez commented 1 year ago

Closed as PR https://github.com/camaraproject/CarrierBillingCheckOut/pull/64 is already triggered