camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family
Apache License 2.0
10 stars 9 forks source link

OPEN QUESTION - Adding Transaction time for a Payment #56

Closed PedroDiez closed 1 year ago

PedroDiez commented 1 year ago

Question raised by STC on 25/JAN meeting regarding both proposals.

Return transaction time of a payment in response (a timestamp). Need to Open an issue on it to detail and provide a way forward. It can make sense to have it.

bigludo7 commented 1 year ago

Thanks One quick clarification. As the POST Payment could not systematically have a successful or synchronous payment processing, the requested timestamp is:

  1. to track the creation of the Payment resource or
  2. to track when the payment has been successfully performed.

For case 1 this is a technical attribute always present present while in case 2 this is an optional attribute.

I guess we want option 2. but looking for your feedback - we can discuss this in next meeting.

CC: @PedroDiez @alabajnaid

PedroDiez commented 1 year ago

I guess the same, the comment is raised for option 2, to have tracking when the payment has successfully accomplished.

Let's talk in the meeting

bigludo7 commented 1 year ago

Proposal after February 1st meeting We could add 2 attributes. These 2 attributes are optional and are valued by the server side:

(attribute name is subject to your suggestion).

PedroDiez commented 1 year ago

To me makes sense @bigludo7.

To include in a higher version. With this notation:

Also would make sense to include payment_date in the notification body (when payment notification is generated about its confirmation)

PedroDiez commented 1 year ago

NOTE: As per guidelines, https://github.com/camaraproject/WorkingGroups/blob/main/Commonalities/documentation/API-design-guidelines.md

input/output params will be snake_case, so for a v1 we need to check in both proposals we are compliance with it.

https://github.com/camaraproject/WorkingGroups/blob/main/Commonalities/documentation/API-design-guidelines.md#42-inputoutput-resource-definition

_These considerations are below:

bigludo7 commented 1 year ago

I have tracked the snake_case in another issue. As we have a lot of api not aligned (Qod, SimSwap) I'm more and more uncomfortable with the snake_case...but that another discussion.

Meanwhile, proposal for date is there: https://github.com/camaraproject/CarrierBillingCheckOut/pull/60

Let review this and once agree I will update the documentation.

PedroDiez commented 1 year ago

Set to closed as covered in PRs: https://github.com/camaraproject/CarrierBillingCheckOut/pull/60 and https://github.com/camaraproject/CarrierBillingCheckOut/pull/64