search

camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family
Apache License 2.0
9 stars 9 forks source link

Design Guidelines: HTTP Status Code type should be Integer, not String #58

Closed bigludo7 closed 1 year ago

bigludo7 commented 1 year ago

Hi We need to change again :)

See https://github.com/camaraproject/WorkingGroups/issues/143

No hurry there for next API update we should align.

PedroDiez commented 1 year ago

hahaha, yes Ludovic.

Let's wait until the conclusion of that track, because as an integer, "pattern" concept does not apply but the use of: minimum: maximum: probably would be the suitable one. Think this is gonna be moved in Commonalities

PedroDiez commented 1 year ago

Let's keep this Issue Open. Think can take still some time to have an alignment. Just to have track of it when considering this in a higher version

PedroDiez commented 1 year ago

Open thread in Commonalities: https://github.com/camaraproject/WorkingGroups/issues/151

PedroDiez commented 1 year ago

Currently being addressed in https://github.com/camaraproject/WorkingGroups/pull/162

Model is the one fllowed within WG, just will take out pattern from "status" as pattern applies for string fields

PedroDiez commented 1 year ago

Set to closed as covered in PRs: https://github.com/camaraproject/CarrierBillingCheckOut/pull/60 and https://github.com/camaraproject/CarrierBillingCheckOut/pull/64