search

camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family
Apache License 2.0
9 stars 9 forks source link

Github PR Template #72

Closed ShutingQing closed 11 months ago

ShutingQing commented 1 year ago

Add pr template discussed in the working group. https://github.com/camaraproject/WorkingGroups/blob/main/Commonalities/documentation/Issue%20and%20PR%20template%20Howto.md

PedroDiez commented 1 year ago

Please @ShutingQing, do not include so far the update in Maintainers. Explanation is provided within

https://github.com/camaraproject/CarrierBillingCheckOut/pull/82

ShutingQing commented 1 year ago

Modified.

PedroDiez commented 12 months ago

Please @ShutingQing can you address Rafal's comments?

ShutingQing commented 12 months ago

Resolved Rafal's comment for file changes. About the label, hi @rartych, do you mean by label the issue to subproject management? @PedroDiez I don't think i have the option to label the issue. Could you pls check the repository settings?

PedroDiez commented 11 months ago

@rartych How this labelling has been performed in Identity and Consent Management?. I have been checking in their repo and do not find something related to

_In order to fully support automatic issue labeling 2 labels need to be added (created): correction , subproject management.

(In Identity and Consent subprojects the label colors were set to #DB2F1F and #515C8B respectively)_

rartych commented 11 months ago

How this labelling has been performed in Identity and Consent Management?. I have been checking in their repo and do not find something related to

_In order to fully support automatic issue labeling 2 labels need to be added (created): correction , subproject management.

(In Identity and Consent subprojects the label colors were set to #DB2F1F and #515C8B respectively)_

@PedroDiez The labels should be added manually (I haven't found a way to automate it - I guess Codeowner rights are enough) in: https://github.com/camaraproject/CarrierBillingCheckOut/labels compare with: https://github.com/camaraproject/IdentityAndConsentManagement/labels

PedroDiez commented 11 months ago

515C8B

Pedro: have already created

PedroDiez commented 11 months ago

Think now PR is ready, any case please take a look @rartych

rartych commented 11 months ago

I do not think that the Bug template will be used as it is intended for Provider implementation repositories. So the issue_bug_template.md file can be removed from this PR. But we can keep it and simply do not use the template.

PedroDiez commented 11 months ago

I do not think that the Bug template will be used as it is intended for Provider implementation repositories. So the issue_bug_template.md file can be removed from this PR. But we can keep it and simply do not use the template.

Please consider this @ShutingQing