camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family
Apache License 2.0
9 stars 9 forks source link

Improvement suggestions for merged API #91

Closed eragaji closed 10 months ago

eragaji commented 12 months ago

This issue is for the GET /payments API of the new merged proposal. For the GET /payments API proposed, there are no filter parameters which are proposed. Because of this, this API will return all payments there in the system and not just the payments belonging to a particular merchant. We need to have merchant identifier as mandatory parameter to limit the payment information returned back to the merchant. Please do note that we might have an aggregator in between the merchant application and the Carrier Billing service and in that scenario token might not be helpful to identify the merchant.

Also ideally we should support additional filter parameters like date range for which payment records are needed or payments of specific status. Merchants usually are interested in getting payments for a specific date range or status.

PedroDiez commented 11 months ago

Ericsson view:

Orange view:

Telefonica view:

PedroDiez commented 11 months ago

Related PR: https://github.com/camaraproject/CarrierBillingCheckOut/pull/96

PedroDiez commented 10 months ago

Closed as PR Merged