retrieve_payments_filtering_Issue91

camaraproject / CarrierBillingCheckOut

Repository to describe, develop, document and test the Carrier Billing Check Out API family

Apache License 2.0

9 stars 9 forks source link

retrieve_payments_filtering_Issue91 #96

Closed PedroDiez closed 10 months ago

PedroDiez commented 11 months ago

What type of PR is this?

enhancement

What this PR does / why we need it:

API version target: v0.2

Define filtering criteria for GET /payments
Aligned "x-correlator" header in some exceptions
Aligned exceptions for POST /payments and POST /payments/prepare
Covering comments about startDate, endDate and date-time fields format.

Which issue(s) this PR fixes:

Usage: Fixes #91

PedroDiez commented 10 months ago

Just one last comment: Accordingly to the guidelines (https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#83-filtering) should not be paymentCreationDate.gte than StartPaymentCreationDate and paymentCreationDate.lte than EndpaymentCreationDate ? WDYT?

Get you point Ludovic, I am using them as "artifacts" (schema object to refer to the specific query param names). In the API spec instantation they are reflected as per the guidelines