search

camaraproject / Commonalities

Repository to describe, develop, document and test the common guidelines and assets for CAMARA APIs
Apache License 2.0
9 stars 24 forks source link

Added 501 Not Supported error response #145

Open mhfoo opened 4 months ago

mhfoo commented 4 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Enhancement as per #138 Proposal to add 501 Not Supported error response

Which issue(s) this PR fixes:

Fixes #138

Special notes for reviewers:

Changelog input

release-note
+ Add 501 Not Supported error response

Additional documentation

This section can be blank.

docs
mhfoo commented 3 months ago

@rartych @shilpa-padgaonkar @patrice-conil @RubenBG7 @PedroDiez

Kindly review this pull request for merging please.

rartych commented 1 month ago

@mhfoo As we agreed on the last Commonalities meeting could you modify your proposal to:

  NotSupported:
   description: Not Supported
   content:
    application/json:
     schema:
      $ref: "#/components/schemas/ErrorInfo"
     example:
      status:  422
      code: NOT_SUPPORTED
      message: Service not supported for this device

Further discussion is possible, but for now we have consensus to use 422.

mhfoo commented 1 month ago

@mhfoo As we agreed on the last Commonalities meeting could you modify your proposal to:

  NotSupported:
   description: Not Supported
   content:
    application/json:
     schema:
      $ref: "#/components/schemas/ErrorInfo"
     example:
      status:  422
      code: NOT_SUPPORTED
      message: Service not supported for this device

Further discussion is possible, but for now we have consensus to use 422.

@rartych

In last Commonalities meeting, my statement are as follows:

I do not want my PR #145 to block this coming meta-release (Fall24) of Commonalities. Please continue this PR #145 discussion for the next release (Spring25).

rartych commented 1 month ago

@mhfoo Thank you for clarification, I got it wrong. Let's postpone this PR as you suggest.

hdamker commented 1 month ago

@rartych @shilpa-padgaonkar propose to "convert to draft" if this is not an active review