camaraproject / Commonalities

Repository to describe, develop, document and test the common guidelines and assets for CAMARA APIs
Apache License 2.0
12 stars 25 forks source link

[Bugfix]: Linting rules problem with Traffic Influence API #161 #169

Closed VijayKesharwani closed 5 months ago

VijayKesharwani commented 6 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Fixing camara-http-method rule to include parameters as valid identifier under path.

Which issue(s) this PR fixes:

Fixes #161

Special notes for reviewers:

Hello Team, As per the issue #161, this PR solves the problem of giving error on using 'parameters' under path for traffic Influence API yaml file related to camara-http-method linting rule.

Changelog input

 release-note

Additional documentation

This section can be blank.

docs
rartych commented 6 months ago

In order to have simple versioning of linting configuration I would modify the line 3 to sth like: # 19.03.2024 - camara-http-method rule corrected

FabrizioMoggio commented 5 months ago

Can this fix be merged?

rartych commented 5 months ago

@FabrizioMoggio Is it possible for you to test it? I guess the fix works well, If you approve it, it can be merged quickly.

FabrizioMoggio commented 5 months ago

Tested in the TI API, it works.

rartych commented 5 months ago

@FabrizioMoggio Thank you for your feedback.