camaraproject / Commonalities

Repository to describe, develop, document and test the common guidelines and assets for CAMARA APIs
Apache License 2.0
9 stars 24 forks source link

update-design-doc-with-explicit-sub-scope-changes #177

Closed shilpa-padgaonkar closed 2 months ago

shilpa-padgaonkar commented 3 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Explicit subscriptions need to be transparent about the event types that they offer. Following changes are included:

Which issue(s) this PR fixes:

Fixes #163

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs
shilpa-padgaonkar commented 3 months ago

Changed PR to draft based on subscription related discussion. Also need to await feedback & consensus on https://github.com/camaraproject/Commonalities/issues/184

shilpa-padgaonkar commented 2 months ago

@bigludo7 and @PedroDiez : Would be great if you could kindly review the scope related changes for explicit subscriptions documented in the design guidelines and recommend changes if needed.

shilpa-padgaonkar commented 2 months ago

@PedroDiez and @bigludo7 have already approved the PR, but I would need a codeowner approval to be able to merge this. @rartych is on vacation. Could either @patrice-conil or @RubenBG7 kindly approve the PR?

bigludo7 commented 2 months ago

@shilpa-padgaonkar my colleague Patrice is also enjoying well-deserved vacation :) Hope @RubenBG7 will be able to help.

RubenBG7 commented 2 months ago

Done @shilpa-padgaonkar