Alignment_with_PR_198 - Githubissues

camaraproject / Commonalities

Repository to describe, develop, document and test the common guidelines and assets for CAMARA APIs

Apache License 2.0

9 stars 24 forks source link

Closed PedroDiez closed 1 month ago

PedroDiez commented 1 month ago

Add one of the following kinds:

Align template with #198

Fixes #185 #153

 release-note
- Add `ACCESS_TOKEN_EXPIRED` termination reason value
- Document `notificationsBearerAuth`

This section can be blank.

docs

shilpa-padgaonkar commented 1 month ago

@PedroDiez and @bigludo7 Do we also want to align this to the PR #194 discussion and get rid of 415 error as well?

PedroDiez commented 1 month ago

I think it is already aligned Shilpa (let's see also Ludovic's view). My understanding:

https://github.com/camaraproject/Commonalities/blob/db4c82976c560fa379cd6e8cc0f391db45569164/artifacts/camara-cloudevents/event-subscription-template.yaml#L51 (415 is removed from notification (callback))
Error "415" is defined/kept for POST /subscriptions (i.e. the case where request body is not in application/json, in this case I assume is being kept due to the input comes from API client and it would be a possible scenario)

shilpa-padgaonkar commented 1 month ago

@PedroDiez Yes, that's correct, for subscriptions it could still be a possible scenario..