search

camaraproject / Commonalities

Repository to describe, develop, document and test the common guidelines and assets for CAMARA APIs
Apache License 2.0
12 stars 25 forks source link

Adding `SUBSCRIPTION_DELETED` as a `terminationReason` [event-subscription-template.yaml] #237

Closed maxl2287 closed 3 months ago

maxl2287 commented 3 months ago

Problem description As of now we have the current valid values of terminationReason:

    TerminationReason:
      type: string
      description: |
        - NETWORK_TERMINATED - API server stopped sending notification
        - SUBSCRIPTION_EXPIRED - Subscription expire time (optionally set by the requester) has been reached
        - MAX_EVENTS_REACHED - Maximum number of events (optionally set by the requester) has been reached
        - ACCESS_TOKEN_EXPIRED - Access Token sinkCredential (optionally set by the requester) expiration time has been reached
      enum:
        - MAX_EVENTS_REACHED
        - NETWORK_TERMINATED
        - SUBSCRIPTION_EXPIRED
        - ACCESS_TOKEN_EXPIRED

But we do not have a termination-reason when the Subscription was deleted by the User.

Possible evolution Add SUBSCRIPTION_DELETED as a new terminationReason.

Related Issues

PedroDiez commented 3 months ago

To me is fine, when discussing the model we initiallly decided to not explicitly add it. If it is consensus, no problem on adding it from our side. cc @bigludo7 , @shilpa-padgaonkar for them to be aware of this topic