camaraproject / DeviceLocation

Repository to describe, develop, document and test the DeviceLocation API family
Apache License 2.0
21 stars 33 forks source link

Update location-retrieval.yaml for release candidate #114

Closed bigludo7 closed 8 months ago

bigludo7 commented 9 months ago

Prepare PR for location-retrieval release candidate issue #112

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Prepare release candidate for location-retrieval

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Not yet ready for merging --> waiting for ipv6 resolution

Changelog input

 release-note
- Changed version to v0.1.0-rc

Additional documentation

This section can be blank.

docs
jlurien commented 9 months ago

We can also adjust some misalignments regarding Errors:

as in https://github.com/camaraproject/DeviceLocation/pull/104/files#diff-

jlurien commented 9 months ago

Aligned error description and message. @jlurien not sure to get all request because in https://github.com/camaraproject/DeviceLocation/pull/104/files we still have message: "Operation not allowed: ..." for 403 for example.

Yes, in some cases, the message has a different explanation, but in the corrected cases the difference with the new CODE is more noticiable. I guess we have a lot of variety across the APIs

jlurien commented 8 months ago

@bigludo7, please tale a look to the new Device model approved by QoD: https://github.com/camaraproject/DeviceLocation/issues/117

I have already adjusted location-verification.yaml

bigludo7 commented 8 months ago

@bigludo7, please tale a look to the new Device model approved by QoD: #117

I have already adjusted location-verification.yaml

Done. I've removed the 'don't merge' tag as I guess we're almost ready.