camaraproject / DeviceLocation

Repository to describe, develop, document and test the DeviceLocation API family
Apache License 2.0
21 stars 33 forks source link

Update geofencing.yaml for release candidate 0.1.0-rc #116

Closed akoshunyadi closed 8 months ago

akoshunyadi commented 9 months ago

What type of PR is this?

What this PR does / why we need it:

According to #112

Prepared release-candidate 0.1.0-rc, including some corrections

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

- Changed version to v0.1.0-rc

Additional documentation

jlurien commented 9 months ago

Hi @akoshunyadi, please take a look into the conflicts, due to the other PR https://github.com/camaraproject/DeviceLocation/pull/115 being recently merged

jlurien commented 9 months ago

We can also adjust some misalignments regarding Errors:

as in https://github.com/camaraproject/DeviceLocation/pull/104/files#diff-4d5f8ffcf7c3ed5fd9dcf63999a1413cba4fee213f2ae8dbf67efc460427a1ccR370-R395

rartych commented 9 months ago

Since multiple examples are not possible in Schema Object prior OAS 3.1.0 I propose to modifySource component definition as follows:

Source:
      type: string
      format: uri-reference
      minLength: 1
      description: |
        Identifies the context in which an event happened - be a non-empty `URI-reference` like:
        - URI with a DNS authority:
          * https://github.com/cloudevents
          * mailto:cncf-wg-serverless@lists.cncf.io
        - Universally-unique URN with a UUID:
          * urn:uuid:6e8bc430-9c3a-11d9-9669-0800200c9a66
        - Application-specific identifier:
          * /cloudevents/spec/pull/123
          * 1-555-123-4567
      example: "https://notificationSendServer12.supertelco.com"
jlurien commented 8 months ago

@akoshunyadi , @rartych , please tale a look to the new Device model approved by QoD: https://github.com/camaraproject/DeviceLocation/issues/117

I have already adjusted location-verification.yaml

bigludo7 commented 8 months ago

Thanks @akoshunyadi 2 smalls comments:

akoshunyadi commented 8 months ago

@bigludo7 sure, I can change that, I think also other date-time fields are affected.