search

camaraproject / DeviceLocation

Repository to describe, develop, document and test the DeviceLocation API family
Apache License 2.0
20 stars 33 forks source link

Global fixes for minor updates & corrections #142

Closed bigludo7 closed 5 months ago

bigludo7 commented 6 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

(all) Correct YAML examples to use upper case enum of areaType (geofencing) Rename in the OAS SubscriptionEventType to NotificationEventType (retrieval) Fix format for attribute lastLocationTime in location retrieval (retrieval & verification) Revise Description to Meet GDPR Compliance - REMOVAL OF " Location-based advertising" in Documentation (sentence from @iamdatanick proposal)

Which issue(s) this PR fixes:

Fixes #136 Fixes #139 Fixes #137 Fixes #135

Special notes for reviewers:

Changelog input

 Correct YAML examples to use upper case enum of areaType
-For geofencing: Rename in the OAS SubscriptionEventType to NotificationEventType
-For Retrieval:  Fix format for attribute lastLocationTime in location retrieval 
Revise Description to Meet GDPR Compliance - REMOVAL OF " Location-based advertising" in Documentation

Additional documentation

This section can be blank.

docs
jlurien commented 5 months ago

Should we create the rc2 now? or do we wait after the next meeting?

akoshunyadi commented 5 months ago

I think, if this PR is merged we can create the RC2

bigludo7 commented 5 months ago

Fixed the line 204 - sorry Akos for the misunderstanding - for me once merge we can create RC2.