feat: add subscriptionMaxEvents for maximum number of notifications (geofencing)

camaraproject / DeviceLocation

Repository to describe, develop, document and test the DeviceLocation API family

Apache License 2.0

20 stars 33 forks source link

feat: add subscriptionMaxEvents for maximum number of notifications (geofencing) #163

Closed maxl2287 closed 4 months ago

maxl2287 commented 4 months ago

What type of PR is this?

Add one of the following kinds:

enhancement/feature
correction

What this PR does / why we need it:

Based on the updated guidelines the subscriptionMaxEvents is added as an optional parameter to define after how many events the subscription will end. (#111)
Define the subscriptionExpireTime as optional in the descriptions (#161)

Which issue(s) this PR fixes:

Fixes #111 Fixes #161

maxl2287 commented 4 months ago

@bigludo7 v0.2.0 for DeviceLocation was released yesterday. This is the new version for Geofencing API, which will be v0.2.0 for this API next, but will be included in the next DeviceLocation release v0.3.0.

That's why I used here v0.2.0-wip.

jlurien commented 4 months ago

Yes, until we have clear rules for API family versioning, I think we should continue with our current one, so new updates on geofencing should be part of 0.2.0-wip

maxl2287 commented 4 months ago

thanks for the review. I will adapt the changes and close the other one