camaraproject / DeviceLocation

Repository to describe, develop, document and test the DeviceLocation API family
Apache License 2.0
21 stars 32 forks source link

Based on the new explicit subscriptions guideline in commonalities, change name of geofencing API to include the keyword subscriptions #190

Closed shilpa-padgaonkar closed 4 months ago

shilpa-padgaonkar commented 5 months ago

Problem description To make the scope naming aspect simpler, the new explicit subscriptions guideline in commonalities mandates the APIs which offer explicit subscriptions to include the keyword "subscriptions" in its name.

Expected behavior Change API name from geofencing to geofencing-subscriptions

Alternative solution

Additional context Commonalities - PR171

maxl2287 commented 4 months ago

@shilpa-padgaonkar does this also requires the change of the API-name to /geofencing-subscriptions/v0 or only the name of the file to geofencing-subscriptions.yaml

jlurien commented 4 months ago

We have to change the basePath, and accordingly rename the file. Also review the descriptions, API title would also need to be changed to "Device Geofencing Subscritiptions" for coherence.

jlurien commented 4 months ago

@shilpa-padgaonkar, what about event names? should we have to rename them as well to org.camaraproject.geofencing-subscriptions.v0.area-left?