search

camaraproject / DeviceLocation

Repository to describe, develop, document and test the DeviceLocation API family
Apache License 2.0
21 stars 32 forks source link

Remodel Area as inheritance #72

Closed jlurien closed 1 year ago

jlurien commented 1 year ago

Problem description

Area uses a polymorphic model (oneOf)

Expected behavior

Guidelines favor inheritance (allOf)

Alternative solution

Remodel Area a base class and Circle as child

Additional context

jlurien commented 1 year ago

@bigludo7 I realise that here we use also oneOf instead of allOf. I guess we'll have to align with ongoing discussions elsewhere.

bigludo7 commented 1 year ago

@jlurien Yes.

I'm reviewing quickly PR#71 - we can perhaps first merge this one and after manage removal oneOf.

I do not have oneOf in raw location API (I sent a reminder to move on this one also).