search

camaraproject / DeviceStatus

Repository to describe, develop, document and test the Device Status API family
Apache License 2.0
11 stars 33 forks source link

Add termination reason `SUBSCRIPTION_DELETED` when subscription deleted by the user #121

Closed maxl2287 closed 6 days ago

maxl2287 commented 4 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Adds a new termination-reason for "subscription-ends" - CloudEvent, when the user deletes the subscriptions via DELETE /subscriptions/{subscriptionId}

Which issue(s) this PR fixes:

Fixes #117

akoshunyadi commented 4 months ago

We should wait until the problem is solved in commonalities, we don't want to have proprietary solutions in each API

akoshunyadi commented 4 months ago

The discussion about subscription lifecycle management in commonalities: https://github.com/camaraproject/Commonalities/issues/153

maxl2287 commented 2 months ago

waiting for megalinter fixes which are already done by #146

maxl2287 commented 3 weeks ago

@camaraproject/device-status_maintainers This can be reviewed and possibly merged after https://github.com/camaraproject/Commonalities/pull/238 is merged

maxl2287 commented 3 weeks ago

The related Communality issue is closed. So we are ready to merge this one here.