Closed bigludo7 closed 4 days ago
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
โ ACTION | actionlint | 2 | 0 | 0.03s | |
โ OPENAPI | spectral | 5 | 0 | 7.93s | |
โ REPOSITORY | git_diff | yes | no | 0.01s | |
โ REPOSITORY | secretlint | yes | no | 0.78s | |
โ YAML | yamllint | 5 | 0 | 0.9s |
See detailed report in MegaLinter reports
@bigludo7 @akoshunyadi Do we want to do here in this PR the split into 4 Yamls as well?
@maxl2287 we can do the 2 subscription APIs in a 2nd PR to the splitting issue
@maxl2287 we can do the 2 subscription APIs in a 2nd PR to the splitting issue
Both work for me The most convenient for you Max.
2nd PR is #161 for splitting /subscriptions
Aligned device-roaming-status with the work done with device-reacheability-status. Need review by the team (@akoshunyadi @fernandopradocabrillo @maxl2287 @sachinvodafone) :)
Hi team Seems that I've mixed myself for Device Reachability Status yaml (commit https://github.com/camaraproject/DeviceStatus/pull/152/commits/7e002c9b0a58c94eab6c1104e86a0365bc062ebf overrides https://github.com/camaraproject/DeviceStatus/pull/152/commits/b1b96c54cc21dbaa4f4c8bfa8806215f26d30e8c corrections).
I've fixed that (I hope so) + added Authorization and authentication ยง in the doc as suggested by @fernandopradocabrillo for both yaml.
Sorry for the confusion.
Where do we want to delete the old yaml? We could do it in this PR.
I aggree with @akoshunyadi.
@akoshunyadi @maxl2287 added delete the old file in this PR
@sachinvodafone @fernandopradocabrillo may I ask you to review this one for blocking point as we target to merge this one soon. Thanks
@akoshunyadi Due to git hub conflict issue I reinserted the 'old' device-status.yaml file and will remove it an a separate PR. Let's hope it will work.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Separate endpoint yaml for reachability & roaming.
Which issue(s) this PR fixes:
Fixes #125 issue for Device error identifier to be added.
Special notes for reviewers:
Yaml for both roaming & reachability subscription provided once new subscription model merged in Commonalities API name & endpoint to be validated by the team
Changelog input
Additional documentation
This section can be blank.