search

camaraproject / DeviceStatus

Repository to describe, develop, document and test the Device Status API family
Apache License 2.0
11 stars 31 forks source link

split `/subscription`-endpoints into seperate APIs #161

Closed maxl2287 closed 2 weeks ago

maxl2287 commented 3 weeks ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Splits up the subscription-endpoints for reachability and roaming status into seperate YAML-files.

Which issue(s) this PR fixes:

Fixes #125

bigludo7 commented 3 weeks ago

Thanks @maxl2287 for the effort. I guess we have to align with the new model for subscription. Do we handle this in this PR or in a separate one? cc: @akoshunyadi

maxl2287 commented 3 weeks ago

@bigludo7 tbh I would handle this in a seperate PR 😄

Do you both agree?

bigludo7 commented 3 weeks ago

@bigludo7 tbh I would handle this in a seperate PR 😄

Do you both agree?

Works for me. It means that we have to merge this one quickly in order to no block you to move forward with this newt PR - Correct?

akoshunyadi commented 3 weeks ago

ok for me. Yes, then then we need an additional PR for the subscriptions.

maxl2287 commented 3 weeks ago

@sachinvodafone thanks for the findings!

maxl2287 commented 3 weeks ago

@bigludo7 can we label this as v0.6.0 ? (I am not allowed to 🥲 )

maxl2287 commented 3 weeks ago

@bigludo7 I was needed to update the file-name to device-reachability-status-subscriptions.yaml

Please review again :)

akoshunyadi commented 2 weeks ago

@maxl2287 we can also merge this PR as it is since #162 needs to be done anyway, which will rework it, right?