search

camaraproject / DeviceStatus

Repository to describe, develop, document and test the Device Status API family
Apache License 2.0
11 stars 33 forks source link

Make Device attribute optional in device-roaming-status & device-reachability-status #173

Closed bigludo7 closed 2 months ago

bigludo7 commented 3 months ago

Problem description As discussed in Commonalities issue#171 & PR233 we need to shift the device object to optional.

Expected behavior Apply the mechanism to rely on the access_token (not providing the device object in the API request) for 3-legged access scenarios. This would fix interoperability in all these scenarios, which is a huge improvement. We can define the device identifier as optional in the API specification and, if not provided, simply refer to access_tokehttps://github.com/camaraproject/Commonalities/pull/233n. The developer would simply not provide any further device information, which is simpler. The operator does not need to check that the device identifier actually matches the access_token provided and could simply rely on the access_token itself.

Alternative solution

Additional context

maxl2287 commented 3 months ago

Hi @bigludo7, is this also required for the subscription-APIs?

bigludo7 commented 3 months ago

Hi @bigludo7, is this also required for the subscription-APIs?

Fair question ! The subscription will be handled by 3-legs so I guess getting the phone number via the access token is perfectly valid... consequently the phone number could be optional. So regarding your question for me Yes

To simplify our work we can probably craft 2 PR: one under your name for the 2 subscriptions yaml and one for me for the 2 other APIs. Works for you?

maxl2287 commented 3 months ago

@bigludo7, Sure :)