camaraproject / EdgeCloud

Repository to describe, develop, document and test the EdgeCloud API family
Apache License 2.0
13 stars 44 forks source link

Simple edge discovery: spelling and linting #223

Closed nicolacdnll closed 3 months ago

nicolacdnll commented 3 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Abide with the Megalinter workflow and spelling. Changes to the API itself need a dedicated PR.

Current linting is complaining about these two lines that are a regex and I'm not sure how to hard wrap. In any case, we can use equivalent regex that are also shorter. But that's for another PR.

- pattern: "^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])$"
- pattern: "^((:|(0?|([1-9a-f][0-9a-f]{0,3}))):)((0?|([1-9a-f][0-9a-f]{0,3})):){0,6}(:|(0?|([1-9a-f][0-9a-f]{0,3})))$" 

image

Which issue(s) this PR fixes:

None

github-actions[bot] commented 3 months ago

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ JSON eslint-plugin-jsonc 1 0 0 1.32s
✅ JSON jsonlint 1 0 0.17s
✅ JSON prettier 1 1 0 0.98s
✅ JSON v8r 1 0 1.85s
❌ OPENAPI spectral 9 7 17.0s
✅ REPOSITORY git_diff yes no 0.55s
✅ REPOSITORY secretlint yes no 4.6s
❌ YAML yamllint 9 1 4.48s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

Kevsy commented 3 months ago

Approved - thanks @nicolacdnll for the good work! - and I will port the new format into #194 (The Simple Edge Discovery PR with substantial content changes). Also noted that the README will need to change in a separate PR.