camaraproject / EdgeCloud

Repository to describe, develop, document and test the EdgeCloud API family
Apache License 2.0
13 stars 44 forks source link

Update Traffic_Influence_API_Readiness_Checklist.md #224

Closed FabrizioMoggio closed 2 months ago

FabrizioMoggio commented 3 months ago

the API implementation is not Mandatory

What type of PR is this?

What this PR does / why we need it:

to be aligned with: https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Readiness-Checklist.md

github-actions[bot] commented 3 months ago

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ JSON eslint-plugin-jsonc 1 0 0 1.31s
✅ JSON jsonlint 1 0 0.17s
✅ JSON prettier 1 1 0 0.91s
✅ JSON v8r 1 0 1.96s
❌ OPENAPI spectral 9 7 17.0s
✅ REPOSITORY git_diff yes no 0.55s
✅ REPOSITORY secretlint yes no 4.48s
❌ YAML yamllint 9 1 4.51s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

FabrizioMoggio commented 2 months ago

I don't get why this PR is blocked. It seams to me that MegaLinter detects an error on other yaml files (e.g. MEC exposure and experience management.yaml).

@javierlozallu have you any suggestion? Is there any action I need to do?

javierlozallu commented 2 months ago

Yes, MegaLinter is controlling the yaml format and we need to adapt the line length to 80 characters. SED and LCM are already adapted, you can check it out. But we have some old YAMLs that need to be adapted if we have to keep them or delete them. But you can merge this PR now that I have approved.

gunjald commented 2 months ago

We should have a way to tell mega linter what files are to be checked instead of whole repository. Or we move the files not required in some achieves.