Updating requiredResources in Application Management API

camaraproject / EdgeCloud

Repository to describe, develop, document and test the EdgeCloud API family

Apache License 2.0

16 stars 43 forks source link

Updating requiredResources in Application Management API #280

Open felipevicens opened 3 months ago

felipevicens commented 3 months ago

What type of PR is this?

enhancement

What this PR does / why we need it:

Enables the definition of different infrastructure for the application, allowing selection from among Kubernetes, Virtual Machines, and Containers. Additionally, the developer can specify the sizing of Kubernetes cluster for the application, the characteristics of compute resources, and the base add-ons to enabling monitoring and ingress in Kubernetes clustes.

Moreover, this PR changes requiredResources to a set of infrastructure resorces, enabling developers to specify more than one resource for the application. For example, an application composed of two containers and one virtual machine.

Which issue(s) this PR fixes:

Fixes #253 Discussion #220

Special notes for reviewers:

This PR only applies to requiredResources in Application Management API

Changelog input

 Modify requiredResources in Application Management API

linux-foundation-easycla[bot] commented 2 weeks ago

:x: The email address for the commit (1f3826a8d70bfc4567762f2b309a987a1ace0d0e, bc455b1f86c0ce32b715cc889565bbd3c30d1db5, b291c76ecc808f191c64454805621ceb423be04e, 891a083b2da6c2cd2618cecea40bc53c405fbd39, c276faf095c5e41e84e5e429d44fced2d6cca4d4, f79413b1514d7d80cb5a62184294424446420753, d6fbf6088e9a42cebf405081f47a4a5f99ddd2dd, c76ff7733e98e2c37189fdca8ccc78bf5f7076c8) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

gainsley commented 1 week ago

Not for this PR, but we may want to consider adding a disk space requirement to the Kubernetes Topology and VmResources/ContainerResources/DockerComposeResources objects. I see they have AdditionalStorage fields, but that seems to be something in addition to the root partition. Users should be able to specify the requirements for the root partition size.

gainsley commented 2 days ago

Also for a follow-up PR, for GPU-specific resources, it does make sense that users would want to be able to reserve GPU VRAM for their LLM/etc usage, but Kubernetes really only allocates gpu resources based on number of gpus. A better understanding of what Kubernetes provides and what the Nvidia operator provides would inform how users would actually be able to specify GPU resources. I think we probably need a num GPUs field, and maybe a GPU type/family as well, but it needs some exploration.