search

camaraproject / Governance

Telco network capabilities exposed through APIs provide a large benefit for customers. By simplifying telco network complexity with APIs and making the APIs available across telco networks and countries, CAMARA enables easy and seamless access.
53 stars 44 forks source link

Proposed text for 'Guidance for closing issues' #137

Open Kevsy opened 1 month ago

Kevsy commented 1 month ago

Fixes #136

What type of PR is this?

What this PR does / why we need it:

Sets a common approach for when issues can be closed.

Which issue(s) this PR fixes:

Fixes #136

Special notes for reviewers:

Additional documentation

This section can be blank.

Bart-Ericsson commented 1 month ago

@Kevsy I tried to propose some changes (see my comments) but then I thought one step further and came to conclusion that it isn't possible to give a guidance which would fit to all kind of issues (e.g. technical, non-technical decisions, proposed enhancements, etc).

In addition is this document here meant more to motivate people to contribute, it wouldn't be helpful to put such formal guidance here.

My proposal is therefore to close the PR and rather spend the energy on the concrete cases if they are coming up and try to solve them in the sense of the ProjectCharter, ProjectStructureAndRoles and the Code of Conduct.

Well, I have seen concrete cases where comments are simply marked as resolved and people try to push their own document through without considering the comments. I'm not sure if it is bad will, but some form of documentation is needed to point to rules in order for them to accept that issues need to be resolved and discussed before simply marking it as resolved.

hdamker commented 4 weeks ago

@Kevsy @eric-murray @bigludo7 I'm not quite sure what to do with this PR. Maybe you might want to add your view.

MarkusKuemmerle commented 4 weeks ago

Please consider also the existing regulations in ProjectStructureAndRoles.md. In the section"Changes and contributions to CAMARA" it is defined that Codeowners shall close the issue.

bigludo7 commented 4 weeks ago

Hi My 2 cents on this topic as codeowner or contributors to several CAMARA API... from my view, in these projets, we go thru the issues during the call and we decide here in the issue needs to be close (and this tabbed in the minutes). If the issue author is not there we can keep it for next meeting but I think as long as the decision is done by the 'team' it seems to be the best solution (which is not contradictory with @MarkusKuemmerle point as the codeowner host the meeting and 'click on the button').

Kevsy commented 4 weeks ago

OK I've committed @hdamker's feedback where indicated. @MarkusKuemmerle I can't see your comments in the PR review...?

Overall: I don't mind which document the guidance goes in, but keeping this PR open for now until we decide where.

MarkusKuemmerle commented 4 weeks ago

@Kevsy : It's the comment in this tread above:

Please consider also the existing regulations in ProjectStructureAndRoles.md. In the section"Changes and contributions to CAMARA" it is defined that Codeowners shall close the issue.

Kevsy commented 4 weeks ago

Thanks Markus - I'm happy to propose the 'guidance for closing issues' text to ProjectStructureAndRoles.md instead, and close this PR. I don't think the problem occurs frequently (@bigludo7 has a good summary of how it is usually done in practice) but as @Bart-Ericsson says, it will be good to have something to point to if needed.