camaraproject / IdentityAndConsentManagement

Repository to describe, develop, document and test the Identity And Consent Management for CAMARA APIs
Apache License 2.0
18 stars 30 forks source link

Add missing response errors in CIBA flow from GSMA doc #114

Closed jpengar closed 1 month ago

jpengar commented 5 months ago

What type of PR is this?

What this PR does / why we need it:

Add some response errors in CIBA documentation according to specification. This PR replicates minor changes in the GSMA doc merged in https://github.com/GSMA-Open-Gateway/Open-Gateway-Documents/pull/86 that have not yet been propagated to CAMARA.

Which issue(s) this PR fixes:

Partially fixes / related to Issue #82.

Special notes for reviewers:

This does not add anything "new", it is just intended to make sure that there is no information documented in GSMA that is missing in CAMARA. Mainly because the GSMA doc is being adapted to reference the CAMARA doc as per #82, and CAMARA must now include all required information.

Full error information will be detailed in any case in CAMARA OIDC profile: https://github.com/camaraproject/IdentityAndConsentManagement/pull/113

Changelog input

Add missing CIBA flow error descriptions from GSMA doc.

Additional documentation

N/A

jpengar commented 3 months ago

@AxelNennker Following analogous reasoning applied to close https://github.com/camaraproject/IdentityAndConsentManagement/pull/123 in today's call (March 13th ICM meeting), I would suggest closing this PR as well. And thus definitely close issue #82. GSMA doc would be adapted to point to the CAMARA OIDC profile as soon as the first version is ready and merged. GSMA Opengateway will simply adopt what is defined in CAMARA OIDC profile as mentioned by them.

jpengar commented 1 month ago

Closing PR as per above comment. Covered by OIDC profile and issue #82 will be fixed by #121