search

camaraproject / IdentityAndConsentManagement

Repository to describe, develop, document and test the Identity And Consent Management for CAMARA APIs
Apache License 2.0
18 stars 30 forks source link

Update README.md #144

Closed wrathwolf closed 1 month ago

wrathwolf commented 2 months ago

Cleaning up meeting invite

jpengar commented 2 months ago

The changes look fine to me, but I think all https://github.com/camaraproject subprojects actually have the existing README structure by default. It sort of keeps consistency between them... Should we change it? For me it is fine either way, it is more of a "cosmetic" thing.

hdamker commented 2 months ago

The changes look fine to me, but I think all https://github.com/camaraproject subprojects actually have the existing README structure by default. It sort of keeps consistency between them... Should we change it? For me it is fine either way, it is more of a "cosmetic" thing.

@jpengar it's part of the initiative to consolidate the information, reduce duplication and make the README.md files usable for inclusion within the sub project wiki "front" page. So the idea is to make all README.md consistent to a new format.

@wrathwolf I propose that we first conclude the PR #3 on the template, before a roll-out to the sub projects.

hdamker commented 2 months ago

I think writing "CET/CEST" is self-contradicting, because a time is either CET or CEST, right? I can't be both at the same time, because CET is without DST, while CEST is with DST. In winter the time is the same, but the spec is either or, I think I think, the text should be 16:00 CEST, but I am not sure about that.

@AxelNennker The logic is that the timezone in EU countries is either CET or CEST (and never both at the same time), and in both cases the meeting is at 16:00. The meeting setup is currently anchored in EU, so it will change automatically with the change to DST in EU (hence the remark about the UTC change if in EU is DT).

If this is the right approach for a global project where this impacts most of the world population which does not have DST (anymore) and especially the southern hemisphere is another question which I will raise as an issue for discussion in Governance.

hdamker commented 2 months ago

Please comment in https://github.com/camaraproject/Template_Lead_Repository/pull/3 regarding the upcoming structure for the README.md. That should be agreed before we touch/change all repositories.

hdamker commented 1 month ago

@wrathwolf @jpengar @AxelNennker with the changes https://github.com/camaraproject/IdentityAndConsentManagement/pull/144/commits/ecab84486736d9aa260a0d58d13455f309bb5d7f I aligned it with Template_Lead_Repository/blob/main/README.md.

Please review and merge if ok.

hdamker commented 1 month ago

I had to delete the doubled section with "Release Information". BTW: feel free to suggest changes to this section if it does not fit for ICM.

AxelNennker commented 1 month ago

I think the following is fitting for API subprojects but not for ICM "Service APIs for “IdentityAndConsentManagement” (see APIBacklog.md)"

Find it strange to view e.g. OIDC as a service API.

jpengar commented 1 month ago

I think the following is fitting for API subprojects but not for ICM "Service APIs for “IdentityAndConsentManagement” (see APIBacklog.md)"

Find it strange to view e.g. OIDC as a service API.

+1. APIBacklog.md link is also broken. We may need to revise the scope section a bit for ICM. It also mentions "Describe, develop, document and test the APIs".

hdamker commented 1 month ago

@AxelNennker @jpengar I corrected the link for APIBacklog.md. But please consider that this PR was opened by @wrathwolf to execute on https://github.com/camaraproject/Governance/issues/124, not to revise the content. The lines within scope you are commenting on are not even changed by this PR. I kindly ask to approve and merge this PR and then open your own issue/PR to revise the content as needed.