search

camaraproject / IdentityAndConsentManagement

Repository to describe, develop, document and test the Identity And Consent Management for CAMARA APIs
Apache License 2.0
18 stars 30 forks source link

CAMARA ICM-examples #148

Closed AxelNennker closed 4 weeks ago

AxelNennker commented 1 month ago

Move CAMARA-ICM-examples.md from fork to this repo

AxelNennker commented 1 month ago

I created https://github.com/AxelNennker/IdentityAndConsentManagement/blob/icm_rar_examples/documentation/ICM_RAR_examples.md to keep the RAR examples. If/when somebody has suggestions on improving that file we could create a PR thus making contributions/suggestions easier.

AxelNennker commented 1 month ago

I removed the RAR example section as suggested by @hdamker and supported by @jpengar and @diegogonmar.

Discussion on how to convey purpose by using RAR continues in https://github.com/camaraproject/IdentityAndConsentManagement/issues/165

Please continue contributing to icm_examples

AxelNennker commented 1 month ago

I think the examples document looks quite good. @hdamker is back on Monday and I assume that his change request was about removing the RAR examples. Not sure why github did not mark that change request as "outdated". Anyway, waiting for Herbert to confirm and approve.

@Elisabeth-Ericsson and @mhfoo do you need further changes, more examples or would you please approve this PR?

AxelNennker commented 1 month ago

I have the impression that this PR is about to be finished. So, I removed the WIP.

AxelNennker commented 1 month ago

@jpengar @sebdewet do you approve this PR?

hdamker commented 1 month ago

@AxelNennker

... I assume that his change request was about removing the RAR examples. Not sure why github did not mark that change request as "outdated". Anyway, waiting for Herbert to confirm and approve.

Your assumption is correct, my request is addressed with the removal of the RAR examples.