search

camaraproject / KnowYourCustomer

Repository to describe, develop, document and test the KnowYourCustomer API family
Apache License 2.0
7 stars 5 forks source link

Align yaml with commonalities v0.3 #103

Open fernandopradocabrillo opened 1 week ago

fernandopradocabrillo commented 1 week ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Align spec yaml with last approved changes from commonalities v0.3

  1. Include Auth section in info.decription
  2. Remove optional "+" prefix from phoneNumber
fernandopradocabrillo commented 1 week ago

Hi @GillesInnov35 @ToshiWakayama-KDDI

Small PR to align the spec with the last approved commonalities changes (v0.3)

GillesInnov35 commented 1 week ago

hi @fernandopradocabrillo , do you know/confirm specifications are already applied on the others Telcos API ?

fernandopradocabrillo commented 1 week ago

hi @fernandopradocabrillo , do you know/confirm specifications are already applied on the others Telcos API ?

do you mean that if other Telcos has implement the KYC API? No idea if this is the case.

or, do you mean if the commonalities changes has been applied in other APIs? In this case, yes, in almost all of them I believe

ToshiWakayama-KDDI commented 1 week ago

Hi @fernandopradocabrillo ,

Thanks for this PR.

Regarding "1. Include Auth section in info.decription", do we have to do this? I would be grateful if you could advise me which commonalities document I can refer to? (API Design Guidelines existing in the Commonalities repo?)

Many thanks,

GillesInnov35 commented 1 week ago

@fernandopradocabrillo, my question concerns phone number format vs new commonalities version

Thanks for your feedback

if the commonalities changes has been applied in other APIs? In this case, yes, in almost all of them I believe

Gilles

ToshiWakayama-KDDI commented 4 days ago

Hi @fernandopradocabrillo ,

Thanks for this PR.

Regarding "1. Include Auth section in info.decription", do we have to do this? I would be grateful if you could advise me which commonalities document I can refer to? (API Design Guidelines existing in the Commonalities repo?)

Many thanks,

Hi @fernandopradocabrillo , Sorry, it seems I misunderstood. This is for Commonalities v0.3, which is the exsiting one.

Best regards, Toshi

fernandopradocabrillo commented 22 hours ago

Hi @ToshiWakayama-KDDI !

Regarding "1. Include Auth section in info.decription", do we have to do this? I would be grateful if you could advise me which commonalities document I can refer to? (API Design Guidelines existing in the Commonalities repo?)

Sure! It is in the ICM repo: https://github.com/camaraproject/IdentityAndConsentManagement/blob/main/documentation/CAMARA-API-access-and-user-consent.md#mandatory-template-for-infodescription-in-camara-api-specs

Sorry, it seems I misunderstood. This is for Commonalities v0.3, which is the exsiting one.

Yes, v0.3 is the current guideline. The releaso of the v0.4 was postponed until mid July I believe.