camaraproject / KnowYourCustomer

Repository to describe, develop, document and test the KnowYourCustomer API family
Apache License 2.0
7 stars 5 forks source link

Cyclic reference in location-verification #70

Closed RobertoSngular closed 2 months ago

RobertoSngular commented 2 months ago

The schema Area refence Circle and Circle reference Area properties

Circle probably doenst need Area properties

I fixed it like this:

Area:
  type: object
  properties:
    areaType:
      $ref: "#/components/schemas/AreaType"
  required:
    - areaType
  discriminator:
    propertyName: areaType
    mapping:
      CIRCLE: "#/components/schemas/Circle"

AreaType:
  type: string
  description: Type of this area. CIRCLE - The area is defined as a circle.
  enum:
    - CIRCLE

Circle:
  description: Circular area
  type: object
  properties:
    center:
      $ref: "#/components/schemas/Point"
    radius:
      type: integer
      description: Expected accuracy for the verification in meters, from location (radius)
      minimum: 2000
      maximum: 200000
  required:
    - center
    - radius
fernandopradocabrillo commented 2 months ago

Hi @RobertoSngular, I think this is in the wrong WG. It seems that this belongs to Device Location

RobertoSngular commented 2 months ago

You are absolutly rigth. i am sorry!