Avoid directly commiting into the `main`-branch

camaraproject / NumberVerification

Repository to describe, develop, document and test the Number Verification API family

Apache License 2.0

16 stars 21 forks source link

Avoid directly commiting into the `main`-branch #112

Closed maxl2287 closed 2 months ago

maxl2287 commented 3 months ago

Describe the bug As I wanted to push a commit and create a branch based on the main-branch, I got the option to directly commit into the main-branch.

Expected behavior We should have here just a proposal commit or just to create a branch based on this and avoid directly commiting as proposed option for a contributer.

hdamker commented 2 months ago

@maxl2287 the main branch in all API and working group repositories is protected with a rule, requiring pull request and at least one code owner approval before the PR can be merged.

For me (with admin rights) it looks like this if I try a direct commit into main:

You shouldn't be able to commit directly into main. Can you check if you by chance tried to commit into your own fork?

maxl2287 commented 2 months ago

Closing it at it's not reproducable anymore! :)