search

camaraproject / NumberVerification

Repository to describe, develop, document and test the Number Verification API family
Apache License 2.0
16 stars 21 forks source link

Release of API version 1.0.0-rc.1 #121

Closed bigludo7 closed 2 months ago

bigludo7 commented 2 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Generation of first release-candidate for NumberVerification API

This first release candidate r1.1 contains the definition and documentation of the release-candidate of the NumberVerification API v1.0.0-rc.1.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs
hdamker commented 2 months ago

@bigludo7 Looks good to me, but I'm not sure why you want to merge the PR into the branch https://github.com/camaraproject/NumberVerification/tree/release-1.0.0-rc1.1 (which is currently 19 commits behind main). At least should the branch be deleted before the release - as it has a confusing numbering. It's protected by the legacy protection rule *release*, so let me know if you want to delete it.

After this is corrected, please add @camaraproject/release-management_maintainers as reviewer.

bigludo7 commented 2 months ago

@bigludo7 Looks good to me, but I'm not sure why you want to merge the PR into the branch https://github.com/camaraproject/NumberVerification/tree/release-1.0.0-rc1.1 (which is currently 19 commits behind main). At least should the branch be deleted before the release - as it has a confusing numbering. It's protected by the legacy protection rule *release*, so let me know if you want to delete it.

After this is corrected, please add @camaraproject/release-management_maintainers as reviewer.

I mixed myself with the branches and then I was stuck because of the release rule. Yes please Herbert delete this branch. I've save all the file so I can make a clean PR on ce the branch deleted; Thanks for your help.

hdamker commented 2 months ago

@bigludo7

I suppose that your files will anyway preserved in https://github.com/camaraproject/NumberVerification/tree/bigludo7-patch-2. I need to close this PR first, to be able to delete the branch.