search

camaraproject / OTPValidation

Repository to describe, develop, document and test the OTP Validation API family
https://wiki.camaraproject.org/display/CAM/OTPValidation
Apache License 2.0
6 stars 13 forks source link

Update one-time-password-sms.yaml #18

Closed bigludo7 closed 1 year ago

bigludo7 commented 1 year ago

Add E164 pattern for Phone number (as in other API)

monamok commented 1 year ago

updated version

Thank you @bigludo7.

We internally usually use: "^+\d{1,15}" But if we want '+' to be optional we should update the description as well.

What do you think about this one?

bigludo7 commented 1 year ago

I've took the pattern from the QoD API which is for me the flagship. I'm not against your proposal but we need to apply it on all the API featuring this msidn/mobileNumber.

monamok commented 1 year ago

I've took the pattern from the QoD API which is for me the flagship. I'm not against your proposal but we need to apply it on all the API featuring this msidn/mobileNumber.

I'm ok with the change you're proposing. I menat that if we change it, this pattern says that '+' is optional but in the description we're saying that it's not. So we should also align the description saying that '+' is optional.

bigludo7 commented 1 year ago

Oh sorry I did get it ! Yes you're right ! I will update the yaml.