camaraproject / OTPValidation

Repository to describe, develop, document and test the OTP Validation API family
https://wiki.camaraproject.org/display/CAM/OTPValidation
Apache License 2.0
6 stars 13 forks source link

initial information (based on Verified MSISDN doc) #2

Closed DT-DawidWroblewski closed 1 year ago

DT-DawidWroblewski commented 1 year ago

Initial content based on Verified MSISDN docs

monamok commented 1 year ago

Thank you @DT-DawidWroblewski for the proposal.

As it was mentioned during the meeting, Mobile Connect offers an OICD flow for authentication using SMS/OTP but the goal of CAMARA is defining APIs not having an authentication flow. In this case we would like to define an API that is used to verify a phone number via sending a SMS and validating the OTP. Similar to my comment on Number Verification I think this API should focus on verifying the number as well. The authentication flow and getting the token, from our point of view should be managed outside of this API. In this case the token can be 2-legged though.

We also believe that using a general endpoint such as /userinfo is not the best option (already mentioned and discussed on commonalities issue #105).

We suggest to have two endpoints, one to send an OTP to the phone number and another to validate the OTP. The operations can be something like this:

_POST /authentication/phone-number/send-code { "phonenumber": "+34628649832", "message": "{{code}} is your short code to authenticate with Cool App via SMS" }

And as a response we can return: _{ "authenticationid": "ea0840f3-3663-4149-bd10-c7c6b8912105" --> unique identifier of this authentication attempt }

And then:

_POST /authentication/phone-number/validate-code { "authenticationid": "ea0840f3-3663-4149-bd10-c7c6b8912105", "code": "AJY3" }

And in the response we can return 200 and the same authenticationid. { "authenticationid": "ea0840f3-3663-4149-bd10-c7c6b8912105" --> unique identifier of this authentication attempt }

As approved Design Guidelines indicate, we should include x-correlator both in query and response headers.

On the other hand, the uploaded version of API_definition is identical to Number Verification and it doesn’t include SMS+OTP specifications. But we can align the documentation once all the participants agree on the API approach.

Looking forward to receiving your feedbacks.

monamok commented 1 year ago

Dear all, based on our conversation on Friday and in order to see better our proposal, I opened this PR.

MarkusKuemmerle commented 1 year ago

@DT-DawidWroblewski : Please contribute API definitions in the code/API_definitions/ subdirectory and not in code/API_code/. Please change this pull request in this way.

DT-DawidWroblewski commented 1 year ago

closing pull request -> changing API definition including name to OTP validation API

MarkusKuemmerle commented 1 year ago

Hello, Sub Project is renamed now to OTPvalidationAPI. @Jose: Would you please update the API backlog? @Mark: Would you please update the name in Openverse? BR, Markus

Von: DawidWroblewski @.> Gesendet: Mittwoch, 14. Dezember 2022 16:22 An: camaraproject/NumberVerificationSMS2FA @.> Cc: Kümmerle, Markus @.>; Comment @.> Betreff: Re: [camaraproject/NumberVerificationSMS2FA] initial information (based on Verified MSISDN doc) (PR #2)

closing pull request -> changing API definition including name to OTP validation API

— Reply to this email directly, view it on GitHubhttps://github.com/camaraproject/NumberVerificationSMS2FA/pull/2#issuecomment-1351621436, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUVD2SDPQVE7POZYIEX52ITWNHQY3ANCNFSM6AAAAAASEI5MLA. You are receiving this because you commented.Message ID: @.**@.>>

MarkusKuemmerle commented 1 year ago

Hi Markus

Will look at updating.

Mark

From: @. @.> Date: Wednesday, 14 December 2022 at 18:31 To: @. @.>, @. @.> Cc: @. @.>, Mark Cornall @.>, JOSE ANTONIO ORDOÑEZ LUCENA @.>, Wróblewski Dawid @.***> Subject: AW: [camaraproject/NumberVerificationSMS2FA] initial information (based on Verified MSISDN doc) (PR #2) “This email has been received from an external source – please review before actioning, clicking on links, or opening attachments”

Hello, Sub Project is renamed now to OTPvalidationAPI. @Jose: Would you please update the API backlog? @Mark: Would you please update the name in Openverse? BR, Markus

Von: DawidWroblewski @.> Gesendet: Mittwoch, 14. Dezember 2022 16:22 An: camaraproject/NumberVerificationSMS2FA @.> Cc: Kümmerle, Markus @.>; Comment @.> Betreff: Re: [camaraproject/NumberVerificationSMS2FA] initial information (based on Verified MSISDN doc) (PR #2)

closing pull request -> changing API definition including name to OTP validation API

— Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcamaraproject%2FNumberVerificationSMS2FA%2Fpull%2F2%23issuecomment-1351621436&data=05%7C01%7Cmcornall%40gsma.com%7C5c2d68459ca9425182f208dade016f67%7C72a4ff82fec3469daafbac8276216699%7C0%7C0%7C638066394995679518%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eSC7TrsPPtnU6ZyXRPla4edYv8HXx9ZchlyOs%2B1AB6w%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUVD2SDPQVE7POZYIEX52ITWNHQY3ANCNFSM6AAAAAASEI5MLA&data=05%7C01%7Cmcornall%40gsma.com%7C5c2d68459ca9425182f208dade016f67%7C72a4ff82fec3469daafbac8276216699%7C0%7C0%7C638066394995679518%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NDoS1XMREhJeVsuRQ90pyXCUuiYqi%2BitTuM1Tf%2Bo%2FmY%3D&reserved=0. You are receiving this because you commented.Message ID: @.**@.>>

.