camaraproject / OTPValidation

Repository to describe, develop, document and test the OTP Validation API family
https://wiki.camaraproject.org/display/CAM/OTPValidation
Apache License 2.0
6 stars 13 forks source link

Missing 404 DEVICE_NOT_FOUND for send-code operation #72

Closed bigludo7 closed 3 months ago

bigludo7 commented 4 months ago

Problem description Missing 404 DEVICE_NOT_FOUND This is defined in https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#62-error-responses---device-object

Expected behavior Add GENERIC_404_DEVICE_NOT_FOUND in Generic404

    Generic404:
      description: Not found
      headers:
        x-correlator:
          $ref: "#/components/headers/x-correlator"
      content:
        application/json:
          schema:
            $ref: "#/components/schemas/ErrorInfo"
          examples:
            GENERIC_404_NOT_FOUND:
              description: Resource is not found
              value:
                status: 404
                code: NOT_FOUND
                message: The specified resource is not found.
            GENERIC_404_DEVICE_NOT_FOUND:
              description: Device identifier not found
              value:
                status: 404
                code: DEVICE_NOT_FOUND
                message: Device identifier not found.

Alternative solution

Additional context

bigludo7 commented 3 months ago

Following discussion with @fernandopradocabrillo and @trehman we decided to not apply this one.