camaraproject / PopulationDensityData

Repository to describe, develop, document and test the Population Density Data API family
Apache License 2.0
3 stars 5 forks source link

Create Gherkin tests for Population Density Data #44

Closed jgarciahospital closed 1 month ago

jgarciahospital commented 3 months ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Including test proposal for population density data 0.1.1

Which issue(s) this PR fixes:

Fixes #37

jgarciahospital commented 1 month ago

See few comments for the test Definition.

Not sure why the README.md & checklist part of this PR.

Thanks Ludo for the review!

readme.md is just to delete the readme of the test definitions folder, now that we have another file. Checklist is just to include the test reference.

jgarciahospital commented 1 month ago

Same here, thanks @bigludo7 . @sachinvodafone please for your validation.

tanjadegroot commented 1 month ago

Ludovic's comments: https://github.com/camaraproject/PopulationDensityData/pull/44/files/6e74f3edccc5fffc682d19fc2c530b71c8fc9871#r1734566694 and https://github.com/camaraproject/PopulationDensityData/pull/44/files/6e74f3edccc5fffc682d19fc2c530b71c8fc9871#r1734573307 are still open

@jgarciahospital @maheshc01 @sachinvodafone please provide your view ASAP as we would like to close the M4 release today if possible.