search

camaraproject / PopulationDensityData

Repository to describe, develop, document and test the Population Density Data API family
Apache License 2.0
2 stars 4 forks source link

Align with Commonalities subscription-model by using sink and sinkCredentials #47

Closed jgarciahospital closed 5 days ago

jgarciahospital commented 1 week ago

What type of PR is this?

Add one of the following kinds:

What this PR does / why we need it:

Fixing small code and documentation typos and including alignment of "$.sink" and "$.sinkCredentials" properties.

Which issue(s) this PR fixes:

Fixes #38

rartych commented 1 week ago

In my view it is not the subscription, but asynchronous response - therefore I opened the issue: https://github.com/camaraproject/Commonalities/issues/297 If we use subscription guidelines the the response should be in Cloudevents format. Since there is no guidelines I am also fine with the proposed changes.

jgarciahospital commented 1 week ago

Thanks, @bigludo7 . @sachinvodafone could you please validate for merging?